Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Auto Suggest] PPL & SQL Value Suggestion #9244

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a7aeb76 from #8275.

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Co-authored-by: Paul Sebastian <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a7aeb76)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 75.44910% with 41 lines in your changes missing coverage. Please review.

Project coverage is 61.76%. Comparing base (5bd7a85) to head (a0e67e3).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ntlr/opensearch_sql/opensearch_sql_autocomplete.ts 68.62% 12 Missing and 4 partials ⚠️
...ntlr/opensearch_ppl/opensearch_ppl_autocomplete.ts 63.88% 7 Missing and 6 partials ⚠️
...ata/public/antlr/opensearch_sql/code_completion.ts 78.78% 3 Missing and 4 partials ⚠️
...ugins/data/public/ui/query_editor/query_editor.tsx 0.00% 3 Missing ⚠️
...ata/public/antlr/opensearch_ppl/code_completion.ts 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #9244      +/-   ##
==========================================
+ Coverage   61.15%   61.76%   +0.61%     
==========================================
  Files        3815     3815              
  Lines       91505    91714     +209     
  Branches    14458    14513      +55     
==========================================
+ Hits        55958    56651     +693     
+ Misses      31990    31441     -549     
- Partials     3557     3622      +65     
Flag Coverage Δ
Linux_1 29.05% <5.48%> (-0.09%) ⬇️
Linux_2 56.60% <ø> (ø)
Linux_3 39.12% <75.44%> (+1.05%) ⬆️
Linux_4 29.08% <5.48%> (-0.10%) ⬇️
Windows_1 29.06% <5.48%> (-0.09%) ⬇️
Windows_2 56.55% <ø> (ø)
Windows_3 39.12% <75.44%> (+1.06%) ⬆️
Windows_4 29.08% <5.48%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli merged commit bc517e4 into 2.x Jan 31, 2025
67 of 68 checks passed
@github-actions github-actions bot deleted the backport/backport-8275-to-2.x branch January 31, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent discover-next failed changeset v2.19.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants