Use Docker image files in dev container config #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See opensafely-core/research-template-docker#32.
In opensafely-core/research-template-docker#57, we moved this configuration to the Docker image.
We can now update the dev container configuration here to use those Docker image files.
Note that
postAttachCommand
now becomes a string, instead of an object; the object format allows for running multiple commands in parallel:https://containers.dev/implementors/json_reference/#formatting-string-vs-array-properties
However, for our use case, this is fine for now as we only run one simple script (that only starts R Studio currently).