-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move postAttach and postCreate actions to Dockerfile #29
Comments
See #29. These were in the `research-template` but we intend to store them here to simplify maintenance. These were taken from opensafely/research-template@5bd648f. Note that the `postAttach.sh` only existed as a line in the `devcontainer.json` and has now been moved to a script.
Repository changes
Documentation changesI don't think that the documentation for adding Codespaces to a project needs updating The steps to update are the same, and there are still multiple files to copy across to a project. If we need to describe the upgrade path, the simplest way to do so would be:
PR to explain the upgrade path (which isn't documented): |
This adds a brief note to explain a task that isn't already documented. Relates to opensafely-core/research-template-docker#29 as the changes there might warrant users upgrading to the latest `.devcontainer` version in the `research-template` repository.
I think merging the PRs above should be sufficient to close this issue. |
See #29. These were in the `research-template` but we intend to store them here to simplify maintenance. These were taken from opensafely/research-template@5bd648f. Note that the `postAttach.sh` only existed as a line in the `devcontainer.json` and has now been moved to a script.
Closing as the related PRs are now merged. |
The research template
devcontainer.json
contains apostCreateCommand
setting andpostAttachCommand
setting. Currently the former calls.devcontainer/postCreate.sh
(which is included in the research template repo), and the latter starts rstudio server.If we wish to make changes to what happens on either of these events, then this currently requires making changes to the research template which:
devcontainer.json
work correctly togetherI propose that:
postCreate.sh
,requirements.in
and a newpostAttach.sh
are added to the image as part of the Dockerfiledevcontainer.json
postCreateCommand
andpostAttachCommand
settings call these scripts.postcreate.sh
andrequirements.in
are removed from the research template repositoryAcceptance criteria
Note: we should keep an eye on how long this work takes and maybe reconsider if it potentially takes us beyond 28th June.
The text was updated successfully, but these errors were encountered: