Improve devcontainers #120
Conversation
lucyb
force-pushed
the
improve-devcontainers
branch
2 times, most recently
from
79b8e09 to
53bcc06
Compare
|
Looking at Tom P's comments in the other thread, I see that not copying across the renv from the OpenSAFELY R action image saves a bunch of space, but unless Tom updates his base image we're going to miss any updates to the OpenSAFELY R package list. Did the base rstudio image not work? |
Jongmassey
force-pushed
the
improve-devcontainers
branch
from
6c0cf3e to
f2394cc
Compare
|
The Dockerfile now references the base rocker image and in my testing works fine. Autocompletion in r-studio works and all the libraries in the renv are present. Image size is now 5.44GB, which isn't great but is better than 8GB. Need to double-check all things Python are fine |
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
|
Just checking - are you sure that renv is configured correctly in this updated version? On starting an RStudio session I think I see only 32 R packages. If I then run 
In More simply you could try copying the packages from the r image into the system R package directories, such as |
This copies the updated dockerfile from the research-template repo (see this [PR](opensafely/research-template#120)).
Jongmassey
force-pushed
the
improve-devcontainers
branch
2 times, most recently
from
fc046f6 to
a17f11a
Compare
Jongmassey
force-pushed
the
improve-devcontainers
branch
from
a17f11a to
597b597
Compare
Use the image from opensafely-core/research-template-docker rather than the Microsoft devcontainer image as a base. For this initial version, I build the image locally and uploaded it using these [instructions](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry).
Co-authored-by: Jon Massey <[email protected]>
Jongmassey
force-pushed
the
improve-devcontainers
branch
2 times, most recently
from
408e1b2 to
f4a799f
Compare
Jongmassey
force-pushed
the
improve-devcontainers
branch
from
d113a9f to
289de8f
Compare
The ehrql extension is downloaded and referenced in vs code separately rather than being installed using pip because it requires a newer version of python (3.11 rather than the 3.10 required for the analysis code). Remove ehrql from requirements.in Co-authored-by: Jon Massey <[email protected]>
This is so we can use the packages copied over from the python action image. Co-authored-by: Jon Massey <[email protected]>
and remove vestigial config added for gitpod
Jongmassey
force-pushed
the
improve-devcontainers
branch
from
289de8f to
ee48aa5
Compare
References opensafely-core#43 and opensafely-core#9
Fixes #104 and opensafely-core#43.
This will provide a development environment for researchers containing:
This can be used in Codespaces or locally via devcontainers in VS Code.