Fix bug logging job-server errors #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebkwok
force-pushed
the
jobserver-error-logs
branch
3 times, most recently
from
7589147 to
9364d59
Compare
rebkwok
changed the title
rebkwok
force-pushed
the
jobserver-error-logs
branch
from
9364d59 to
60eb553
Compare
This is more robust that attempting to retrieve the request id from the release_json.
rebkwok
force-pushed
the
jobserver-error-logs
branch
from
60eb553 to
8b70dea
Compare
rebkwok
changed the title
evansd
approved these changes
Jun 28, 2024
madwort
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the request id to
old_api.create_releaseso that we can log it. Avoids having to retrieve the request id from therelease_json, which could be incorrect.fixes #426