Pass request id to old_api.create_releaase

This is more robust that attempting to retrieve the request id from
the release_json.

airlock/business_logic.py

@@ -1607,7 +1607,10 @@ def release_files(self, release_request: ReleaseRequest, user: User):
 
         filelist = old_api.create_filelist(file_paths, release_request)
         jobserver_release_id = old_api.create_release(
-            release_request.workspace, filelist.json(), user.username
+            release_request.workspace,
+            release_request.id,
+            filelist.json(),
+            user.username,
         )
 
         for relpath, abspath in file_paths:

old_api/__init__.py

@@ -38,7 +38,7 @@ def create_filelist(paths, release_request):
     )
 
 
-def create_release(workspace_name, release_json, username):
+def create_release(workspace_name, release_request_id, release_json, username):
     """API call to job server to create a release."""
     response = session.post(
         url=f"{settings.AIRLOCK_API_ENDPOINT}/releases/workspace/{workspace_name}",
@@ -55,7 +55,7 @@ def create_release(workspace_name, release_json, username):
         logger.error(
             "%s Error creating release - %s - %s",
             response.status_code,
-            release_json["airlock_id"],
+            release_request_id,
             response.content.decode(),
         )
 

tests/integration/test_old_api.py

@@ -20,7 +20,7 @@ def test_old_api_create_release(responses):
 
     assert (
         old_api.create_release(
-            "workspace_name", {"airlock_id": "jobserver-id"}, "testuser"
+            "workspace_name", "jobserver-id", {"airlock_id": "jobserver-id"}, "testuser"
         )
         == "jobserver-id"
     )
@@ -39,7 +39,7 @@ def test_old_api_create_release_with_error(responses, caplog):
     )
     with pytest.raises(requests.exceptions.HTTPError):
         old_api.create_release(
-            "workspace_name", {"airlock_id": "jobserver-id"}, "testuser"
+            "workspace_name", "jobserver-id", {"airlock_id": "jobserver-id"}, "testuser"
         )
     assert len(caplog.messages) == 1
     log = caplog.messages[0]