Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Fix devtools trigger button popover #1272

Merged
merged 2 commits into from
Jan 18, 2025
Merged

(fix) Fix devtools trigger button popover #1272

merged 2 commits into from
Jan 18, 2025
+41 −20

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 18, 2025 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR fixes several issues with the devtools trigger button's popover. Previously, the popover was incorrectly positioned at the top left of the screen and the popover container pushed content below the navbar down by 1rem.

This PR addresses these issues by:

  • Adding a wrapperClasses prop to the IconButton component to apply custom styles to the popover container.
  • Positioning and aligning the popover container to the top left of the devtools trigger button.
  • Adding a box shadow to the popover container to match the help menu button's box shadow for visual consistency.
  • Adjusting the right margin of the devtools trigger button to align with the help menu button.

Additional changes:

  • Adjusting the right margin of the help menu button's popover to align with the devtools trigger button's popover.

Screenshots

Popover trigger incorrectly positioned at the top left of the screen below the navbar

CleanShot 2025-01-18 at 11  47 45@2x

After the fix

CleanShot 2025-01-18 at 11  44 28@2x

CleanShot 2025-01-18 at 11  44 40@2x

Devtools panel close button positioning fix

CleanShot 2025-01-18 at 12  12 28@2x

Related Issue

Other

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025 •
edited
Loading

Size Change: -11.4 kB (-0.18%)

Total Size: 6.19 MB

Filename Size Change
packages/apps/esm-devtools-app/dist/875.js 0 B -11.4 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/373.js 12 kB 0 B
packages/apps/esm-devtools-app/dist/593.js 149 kB 0 B
packages/apps/esm-devtools-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-devtools-app/dist/647.js 2.32 kB 0 B
packages/apps/esm-devtools-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 375 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 325 B 0 B
packages/apps/esm-devtools-app/dist/main.js 3.23 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.28 kB 0 B
packages/apps/esm-help-menu-app/dist/248.js 10.2 kB -5 B (-0.05%)
packages/apps/esm-help-menu-app/dist/474.js 705 B 0 B
packages/apps/esm-help-menu-app/dist/611.js 2.45 kB 0 B
packages/apps/esm-help-menu-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-help-menu-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-help-menu-app/dist/662.js 147 kB 0 B
packages/apps/esm-help-menu-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-help-menu-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-help-menu-app/dist/889.js 375 kB 0 B
packages/apps/esm-help-menu-app/dist/958.js 3.73 kB 0 B
packages/apps/esm-help-menu-app/dist/main.js 8.56 kB 0 B
packages/apps/esm-help-menu-app/dist/openmrs-esm-help-menu-app.js 3.23 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1491.js 134 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1644.js 758 B 0 B
packages/apps/esm-implementer-tools-app/dist/1873.js 3.67 kB 0 B
packages/apps/esm-implementer-tools-app/dist/1901.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/236.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/2735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/2757.js 714 B 0 B
packages/apps/esm-implementer-tools-app/dist/2788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3336.js 137 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3448.js 4.66 kB 0 B
packages/apps/esm-implementer-tools-app/dist/3574.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/3652.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4272.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4378.js 699 B 0 B
packages/apps/esm-implementer-tools-app/dist/4426.js 27.8 kB 0 B
packages/apps/esm-implementer-tools-app/dist/4460.js 786 B 0 B
packages/apps/esm-implementer-tools-app/dist/4705.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/4889.js 375 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5240.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5336.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/539.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5642.js 21.1 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5673.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5711.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5737.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/5833.js 727 B 0 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.93 kB 0 B
packages/apps/esm-implementer-tools-app/dist/5962.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/6566.js 700 B 0 B
packages/apps/esm-implementer-tools-app/dist/667.js 121 kB 0 B
packages/apps/esm-implementer-tools-app/dist/6727.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/7036.js 2.5 kB 0 B
packages/apps/esm-implementer-tools-app/dist/744.js 722 B 0 B
packages/apps/esm-implementer-tools-app/dist/7807.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/7859.js 3.09 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8271.js 753 B 0 B
packages/apps/esm-implementer-tools-app/dist/8289.js 14.3 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8319.js 687 B 0 B
packages/apps/esm-implementer-tools-app/dist/8323.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/845.js 6.43 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8657.js 7.02 kB 0 B
packages/apps/esm-implementer-tools-app/dist/8788.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/899.js 590 B 0 B
packages/apps/esm-implementer-tools-app/dist/9261.js 592 B 0 B
packages/apps/esm-implementer-tools-app/dist/9441.js 4.38 kB 0 B
packages/apps/esm-implementer-tools-app/dist/9579.js 591 B 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 21 kB 0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.4 kB 0 B
packages/apps/esm-login-app/dist/202.js 2.57 kB 0 B
packages/apps/esm-login-app/dist/211.js 35 kB 0 B
packages/apps/esm-login-app/dist/236.js 777 B 0 B
packages/apps/esm-login-app/dist/240.js 842 B 0 B
packages/apps/esm-login-app/dist/261.js 753 B 0 B
packages/apps/esm-login-app/dist/271.js 936 B 0 B
packages/apps/esm-login-app/dist/272.js 765 B 0 B
packages/apps/esm-login-app/dist/319.js 868 B 0 B
packages/apps/esm-login-app/dist/323.js 1.12 kB 0 B
packages/apps/esm-login-app/dist/336.js 838 B 0 B
packages/apps/esm-login-app/dist/378.js 879 B 0 B
packages/apps/esm-login-app/dist/415.js 26.7 kB 0 B
packages/apps/esm-login-app/dist/460.js 991 B 0 B
packages/apps/esm-login-app/dist/539.js 783 B 0 B
packages/apps/esm-login-app/dist/566.js 907 B 0 B
packages/apps/esm-login-app/dist/574.js 752 B 0 B
packages/apps/esm-login-app/dist/579.js 751 B 0 B
packages/apps/esm-login-app/dist/593.js 149 kB 0 B
packages/apps/esm-login-app/dist/625.js 753 B 0 B
packages/apps/esm-login-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-login-app/dist/644.js 934 B 0 B
packages/apps/esm-login-app/dist/652.js 753 B 0 B
packages/apps/esm-login-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-login-app/dist/673.js 792 B 0 B
packages/apps/esm-login-app/dist/676.js 2.23 kB 0 B
packages/apps/esm-login-app/dist/7.js 3.03 kB 0 B
packages/apps/esm-login-app/dist/705.js 753 B 0 B
packages/apps/esm-login-app/dist/711.js 752 B 0 B
packages/apps/esm-login-app/dist/727.js 752 B 0 B
packages/apps/esm-login-app/dist/735.js 2.62 kB 0 B
packages/apps/esm-login-app/dist/737.js 752 B 0 B
packages/apps/esm-login-app/dist/744.js 1.01 kB 0 B
packages/apps/esm-login-app/dist/755.js 3.36 kB 0 B
packages/apps/esm-login-app/dist/757.js 921 B 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/807.js 1.05 kB 0 B
packages/apps/esm-login-app/dist/833.js 889 B 0 B
packages/apps/esm-login-app/dist/859.js 3.08 kB 0 B
packages/apps/esm-login-app/dist/889.js 375 kB 0 B
packages/apps/esm-login-app/dist/899.js 750 B 0 B
packages/apps/esm-login-app/dist/901.js 751 B 0 B
packages/apps/esm-login-app/dist/93.js 2.16 kB 0 B
packages/apps/esm-login-app/dist/962.js 753 B 0 B
packages/apps/esm-login-app/dist/main.js 63.1 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.46 kB 0 B
packages/apps/esm-offline-tools-app/dist/236.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/240.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/261.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/271.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/272.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/319.js 1.16 kB 0 B
packages/apps/esm-offline-tools-app/dist/323.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/336.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/378.js 1.17 kB 0 B
packages/apps/esm-offline-tools-app/dist/460.js 1.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/539.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/566.js 1.17 kB 0 B
packages/apps/esm-offline-tools-app/dist/574.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/579.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/601.js 142 kB 0 B
packages/apps/esm-offline-tools-app/dist/625.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/642.js 21.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/644.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/645.js 91.6 kB 0 B
packages/apps/esm-offline-tools-app/dist/652.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/657.js 7.02 kB 0 B
packages/apps/esm-offline-tools-app/dist/673.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/703.js 6.32 kB 0 B
packages/apps/esm-offline-tools-app/dist/705.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/711.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/727.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/737.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/744.js 1.28 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.19 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/833.js 1.21 kB 0 B
packages/apps/esm-offline-tools-app/dist/859.js 3.09 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 375 kB 0 B
packages/apps/esm-offline-tools-app/dist/899.js 1.02 kB 0 B
packages/apps/esm-offline-tools-app/dist/901.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/947.js 8.66 kB 0 B
packages/apps/esm-offline-tools-app/dist/962.js 1.03 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 107 kB 0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.39 kB 0 B
packages/apps/esm-primary-navigation-app/dist/236.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/238.js 147 kB 0 B
packages/apps/esm-primary-navigation-app/dist/240.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/261.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/271.js 282 B 0 B
packages/apps/esm-primary-navigation-app/dist/272.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/319.js 246 B 0 B
packages/apps/esm-primary-navigation-app/dist/323.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/336.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/378.js 267 B 0 B
packages/apps/esm-primary-navigation-app/dist/459.js 8.64 kB 0 B
packages/apps/esm-primary-navigation-app/dist/460.js 277 B 0 B
packages/apps/esm-primary-navigation-app/dist/482.js 15.2 kB 0 B
packages/apps/esm-primary-navigation-app/dist/539.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/566.js 262 B 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/579.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/619.js 6.45 kB 0 B
packages/apps/esm-primary-navigation-app/dist/625.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-primary-navigation-app/dist/644.js 290 B 0 B
packages/apps/esm-primary-navigation-app/dist/652.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/657.js 7.03 kB 0 B
packages/apps/esm-primary-navigation-app/dist/673.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/705.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/711.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/727.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/737.js 240 B 0 B
packages/apps/esm-primary-navigation-app/dist/744.js 288 B 0 B
packages/apps/esm-primary-navigation-app/dist/757.js 246 B 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/807.js 301 B 0 B
packages/apps/esm-primary-navigation-app/dist/833.js 282 B 0 B
packages/apps/esm-primary-navigation-app/dist/888.js 24.8 kB 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 375 kB 0 B
packages/apps/esm-primary-navigation-app/dist/899.js 237 B 0 B
packages/apps/esm-primary-navigation-app/dist/901.js 239 B 0 B
packages/apps/esm-primary-navigation-app/dist/933.js 3.63 kB 0 B
packages/apps/esm-primary-navigation-app/dist/962.js 241 B 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 30.3 kB 0 B
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.38 kB 0 B
packages/framework/esm-api/dist/openmrs-esm-api.js 16.9 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 8.42 kB 0 B
packages/framework/esm-context/dist/openmrs-esm-context.js 1.16 kB 0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.89 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 891 B 0 B
packages/framework/esm-expression-evaluator/dist/openmrs-esm-expression-evaluator.js 9.02 kB 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 25.5 kB 0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.66 kB 0 B
packages/framework/esm-framework/dist/278.openmrs-esm-framework.js 14.5 kB 0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.93 kB 0 B
packages/framework/esm-framework/dist/588.openmrs-esm-framework.js 2.15 kB 0 B
packages/framework/esm-framework/dist/619.openmrs-esm-framework.js 6.49 kB 0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.3 kB 0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.65 kB 0 B
packages/framework/esm-framework/dist/746.openmrs-esm-framework.js 6.14 kB 0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB 0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js 459 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 791 B 0 B
packages/framework/esm-navigation/dist/openmrs-esm-navigation.js 9.34 kB 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 21.9 kB 0 B
packages/framework/esm-routes/dist/openmrs-esm-utils.js 4.82 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 1.59 kB 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 194 kB 0 B
packages/framework/esm-translations/dist/openmrs-esm-core-translations.js 1.91 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 45.5 kB 0 B
packages/shell/esm-app-shell/dist/0271593110f44328.js 1.22 kB 0 B
packages/shell/esm-app-shell/dist/09faa1eddbfe2b90.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/0b44c109a50e43c9.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/1a51a6a003151018.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/1ae8ee136b34ca0a.js 1.21 kB 0 B
packages/shell/esm-app-shell/dist/26a85b1140d29bc9.js 1.34 kB 0 B
packages/shell/esm-app-shell/dist/38d4b8fb75f8850c.js 18.3 kB 0 B
packages/shell/esm-app-shell/dist/3b01402cd7292844.js 2.85 kB 0 B
packages/shell/esm-app-shell/dist/4013f91dec11c907.js 6.35 kB 0 B
packages/shell/esm-app-shell/dist/42777c9090cd3136.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/4346b9e0476ef283.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/47d5146f0fb8f2ff.js 1.09 kB 0 B
packages/shell/esm-app-shell/dist/4ef6b02fdcbe5a2a.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/53baea24a93b42fc.js 7.12 kB 0 B
packages/shell/esm-app-shell/dist/572e81f004cc10c5.js 15.1 kB 0 B
packages/shell/esm-app-shell/dist/5984886e68ab42a7.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/5b1af61b61090126.js 1.08 kB 0 B
packages/shell/esm-app-shell/dist/5cf52b20f1fc0063.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/6abfecd8abab72e8.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/6e41fed06e56b0f7.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/6f47008d9c93c1cb.js 3.33 kB 0 B
packages/shell/esm-app-shell/dist/71ab27e0b8d1949e.js 2.58 kB 0 B
packages/shell/esm-app-shell/dist/7429825177b56dd6.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/754a7d55aee33755.js 1.33 kB 0 B
packages/shell/esm-app-shell/dist/788fdd707198d0b7.js 6.99 kB 0 B
packages/shell/esm-app-shell/dist/79dddb21109dd857.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/79e0fe636d1ed41c.js 1.59 kB 0 B
packages/shell/esm-app-shell/dist/7b204450699b0daf.js 2.6 kB 0 B
packages/shell/esm-app-shell/dist/7b96597c3e74e0ff.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/82b7bc01481a3111.js 172 kB 0 B
packages/shell/esm-app-shell/dist/857b0585adfa0d27.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/8e0d11f862dfbba6.js 626 B 0 B
packages/shell/esm-app-shell/dist/9c6cd84f3703f9cc.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/a25cd0222d9b0879.js 1.33 kB 0 B
packages/shell/esm-app-shell/dist/a6ec4f7417d5eb40.js 46.9 kB 0 B
packages/shell/esm-app-shell/dist/a7792d6252d85b20.js 43 kB 0 B
packages/shell/esm-app-shell/dist/a7efa2596cd2be4f.js 168 kB 0 B
packages/shell/esm-app-shell/dist/b184fc085e27d29d.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/b407f548b6fadfa3.js 3.08 kB 0 B
packages/shell/esm-app-shell/dist/b87a5878f8961d1a.js 2.23 kB 0 B
packages/shell/esm-app-shell/dist/b88532bde74b513a.js 9.41 kB 0 B
packages/shell/esm-app-shell/dist/bb04bb60f8aa150f.js 3.04 kB 0 B
packages/shell/esm-app-shell/dist/c500b383e68704ce.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/c51c3c9f450d16ef.js 1.31 kB 0 B
packages/shell/esm-app-shell/dist/c79856b32f0aca6b.js 1.22 kB 0 B
packages/shell/esm-app-shell/dist/c7d82d4e666adffa.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/cc0d293bb9b870d9.js 3.38 kB 0 B
packages/shell/esm-app-shell/dist/d441de0181ae25f1.js 66.4 kB 0 B
packages/shell/esm-app-shell/dist/d783daa399ff06a4.js 1.37 kB 0 B
packages/shell/esm-app-shell/dist/d80464c66e5d20d7.js 3.23 kB 0 B
packages/shell/esm-app-shell/dist/db9653c270579a5e.js 1.04 kB 0 B
packages/shell/esm-app-shell/dist/e419a658f4742c3e.js 9.36 kB 0 B
packages/shell/esm-app-shell/dist/f5c65190072bb3f7.js 626 B 0 B
packages/shell/esm-app-shell/dist/fcb385df17a82210.js 6.77 kB 0 B
packages/shell/esm-app-shell/dist/ff8fd36f7a9ca50a.js 3.91 kB 0 B
packages/shell/esm-app-shell/dist/openmrs.14608a502fc58101.js 21.8 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 46.6 kB 0 B
packages/tooling/openmrs/dist/cli.js 2.84 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 3.31 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.34 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 543 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 2.71 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 437 B 0 B
packages/tooling/openmrs/dist/commands/start.js 850 B 0 B
packages/tooling/openmrs/dist/index.js 517 B 0 B
packages/tooling/openmrs/dist/runner.js 640 B 0 B
packages/tooling/openmrs/dist/utils/config.js 726 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 575 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 643 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 397 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 3.21 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 443 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 368 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 831 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 725 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 278 B 0 B
packages/tooling/webpack-config/dist/index.js 3.61 kB 0 B

compressed-size-action

@denniskigen denniskigen requested a review from ibacher January 18, 2025 09:18
@denniskigen
(fix) Fix devtools trigger button popover
aed4f8d 
This PR fixes several issues with the devtools button popover. Previously, the popover was incorrectly positioned at the top left
of the screen and the popover container pushed content below the navbar down by 1rem.

This PR addresses these issues by:

- Adding a `wrapperClasses` prop to the IconButton component to apply custom styles to the popover container
- Positioning and aligning the popover container to the top left of the devtools trigger button
- Adding a box shadow to the popover container to match the help menu button's box shadow for visual consistency
- Adjusting the right margin of the devtools trigger button to align with the help menu button

Additional changes:

- Adjusted the right margin of the help menu button's popover to align with the devtools trigger button's popover
@denniskigen denniskigen force-pushed the fix/devtools-trigger-button branch from 3e5e897 to aed4f8d Compare January 18, 2025 11:28
@ibacher ibacher merged commit 5d655c1 into main Jan 18, 2025
14 checks passed
@ibacher ibacher deleted the fix/devtools-trigger-button branch January 18, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniskigen @ibacher