-
Notifications
You must be signed in to change notification settings - Fork 214
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(fix) Fix devtools trigger button popover
This PR fixes several issues with the devtools button popover. Previously, the popover was incorrectly positioned at the top left of the screen and the popover container pushed content below the navbar down by 1rem. This PR addresses these issues by: - Adding a `wrapperClasses` prop to the IconButton component to apply custom styles to the popover container - Positioning and aligning the popover container to the top left of the devtools trigger button - Adding a box shadow to the popover container to match the help menu button's box shadow for visual consistency - Adjusting the right margin of the devtools trigger button to align with the help menu button Additional changes: - Adjusted the right margin of the help menu button's popover to align with the devtools trigger button's popover
- Loading branch information
1 parent
9603107
commit aed4f8d
Showing
5 changed files
with
40 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletions
13
packages/apps/esm-devtools-app/src/devtools/devtools.styles.css
This file was deleted.
Oops, something went wrong.
28 changes: 28 additions & 0 deletions
28
packages/apps/esm-devtools-app/src/devtools/devtools.styles.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
@use '@carbon/colors'; | ||
@use '@carbon/layout'; | ||
|
||
.devtoolsTriggerButton { | ||
z-index: 7900; | ||
background: colors.$white; | ||
box-shadow: | ||
0 1px 3px rgba(0, 0, 0, 0.1), | ||
0 1px 2px -1px rgba(0, 0, 0, 0.1); | ||
border-radius: layout.$spacing-02; | ||
color: colors.$gray-100; | ||
|
||
&:hover { | ||
color: colors.$blue-60 !important; | ||
} | ||
} | ||
|
||
.overridden { | ||
background-color: colors.$red-30; | ||
color: colors.$white; | ||
} | ||
|
||
.popover { | ||
z-index: 7900; | ||
bottom: layout.$spacing-11; | ||
right: layout.$spacing-02; | ||
position: fixed; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,5 +29,5 @@ | |
z-index: 7900; | ||
bottom: layout.$spacing-07; | ||
position: fixed; | ||
right: 3.25rem; | ||
right: 3rem; | ||
} |