-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support input element (Issue #726) #755
Conversation
dc9c218
to
1c8abb5
Compare
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
1c8abb5
to
9b552d8
Compare
Signed-off-by: Tassilo Karge <[email protected]>
682353a
to
e2a3e0a
Compare
Date input types not working yet, because the alertview layout breaks when adding it. Also, numbers are rounded, but that |
Signed-off-by: Tassilo Karge <[email protected]>
Signed-off-by: Tassilo Karge <[email protected]>
I now added the date and time picker directly to the cell. They show strange behaviour because they often reset when changing the date though. |
5817fd0
to
0a70d0e
Compare
LGTM |
First of all, I very much appreciate you are implementing this for ios. I introduced the functionality in sitemaps and implemented it in BasicUI and the Android app. I use an Android phone and an iPad, so always wanted this available as well. I noticed this comment:
Any idea why it resets? Could it be partial updated info is sent, and comes back from SSE events, and updates it again while still editing? Or is it an issue with the DatePicker? |
Signed-off-by: Tassilo Karge <[email protected]>
7eb6baf
to
861a2b3
Compare
I found some peace to review the issue of resetting values. Turns out, the date that I get with my particular test setup (item of type DateTime, corresponding sitemap input element with hint "Date") gives me a date formatted like "yyyy-MM-dd HH:mm:ss". I am sending an iso-formatted date so I expected the same back, and if I am sending the "yyyy-MM-dd HH:mm:ss" format it is not accepted by OpenHab... But anyway, it´s working now. |
@mherwege for testing a feature branch on your local device you´d need a mac to compile the app, xcode, and (at least I had to do that) adapt some app group and -identifier settings to allow using your personal (unpaid) apple developer account to deploy it to your device. You could probably use all available simulators, too. Automatic upload of TestFlight versions by the developers for every feature branch would probably be too risky, since everyone could open a merge request with any content they want. Also, they would need a mac or pay for some service that provides a mac as build server to be able to compile those versions. |
I got the difference now: One is the widget label value and the other one the item state. Which is the better one to use? The latter is formatted in the same way that I must use for sending events, which seems a sensible choice... |
Signed-off-by: Tassilo Karge <[email protected]>
@TAKeanice thanks a lot for this valuable contribution. @mherwege I will make a TestFlight release available when @TAKeanice is ready |
I am ;) Implemented the last change and tested it yesterday. Date changes work smooth like butter now |
This adds the widget type Input