Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input element in sitemaps. #726

Open
mherwege opened this issue Jul 28, 2023 · 15 comments
Open

Support input element in sitemaps. #726

mherwege opened this issue Jul 28, 2023 · 15 comments

Comments

@mherwege
Copy link

This is an enhancement request.

With OH4, there is now support for input elements in sitemaps. I have implemented this in BasicUI and the Android App. It would be nice for someone to implement this in the IOS app.

@REdelhoff
Copy link

Is there any progress on this feature request? I would also like to be able to enter free text inside the IOS App

@TAKeanice
Copy link
Contributor

The maintainers are currently in the process of recovering their watchId app identifier with Apple and not able to release as far as I know.

Until then, I would like to try and implement that feature. I started on #755 .

@nw378
Copy link

nw378 commented Nov 7, 2024

Any progress on this issue?

@TAKeanice
Copy link
Contributor

I made some, but did not get around to testing it yet and put the task aside for a while. Let me review it this weekend.

@nw378
Copy link

nw378 commented Nov 7, 2024

Good news, looking forward to...

@TAKeanice
Copy link
Contributor

@nw378 I opened the PR #755 for review. Date input is not working yet though.

@TAKeanice
Copy link
Contributor

The PR with support for the sitemap input feature is ready to be reviewed. @timbms @mherwege, @REdelhoff and @nw378 I am looking forward to your feedback!

timbms pushed a commit that referenced this issue Nov 16, 2024
* Input element support for all input type including date
---------

Signed-off-by: Tassilo Karge <[email protected]>
@nw378
Copy link

nw378 commented Nov 17, 2024

@TAKeanice sorry, I'm not so familar with PRs. What do I have to do to review it?

@TAKeanice
Copy link
Contributor

No Problem @nw378 , there were already some maintainers that reviewed what I have implemented. It is now included in this repository and will be included in a future release.

@timbms
Copy link
Contributor

timbms commented Nov 18, 2024

TestFlight release 3.0.8(30) is available.

@nw378
Copy link

nw378 commented Nov 18, 2024

Yes, just got a notification about the new version. It's working proper, thanks alot @TAKeanice !

@nw378
Copy link

nw378 commented Nov 18, 2024

Just tested a bit more @TAKeanice ... Unfortunately, there seems to be a bug:

With more than one item on a site, the input of them interacts accidental.

        Input item=Clock_08 label="Außenleuchten an" icon="clock_dark" inputHint="time" //[JS(numberToClock.js):%s] minValue=0 maxValue=1425 step=15 
        Input item=Clock_09 label="Außenleuchten aus" icon="clock_dark" inputHint="time"
clocks.mp4

@TAKeanice
Copy link
Contributor

Just tested a bit more @TAKeanice ... Unfortunately, there seems to be a bug:

Excellent testing! I will check what causes that behavior. For everyone who doesn't recognize it immediately (I also had to watch the video several times): The date picker of one time (morgens Außenleuchten an) gets set to another time that wa previously input for a different item (abends Außenleuchten aus, 7:30). It happens in the last 10s of the video.

@nw378
Copy link

nw378 commented Nov 19, 2024

yes, and the date picker itself is also jumping. Hard to explain. you have to try it yourself.

@timbms
Copy link
Contributor

timbms commented Nov 19, 2024

This sounds like a similar problem to #646 addressed by #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants