Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache.py #199

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update cache.py #199

merged 1 commit into from
Oct 17, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

Copy cache items before iterating

Helps with #186

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

sentry-io bot commented Oct 17, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: pv_site_api/cache.py

Function Unhandled Issue
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/{site_uuid}/pv_fo...
Event Count: 10
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/pv_...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@peterdudfield peterdudfield merged commit 6254d47 into main Oct 17, 2024
3 checks passed
@peterdudfield peterdudfield mentioned this pull request Oct 17, 2024
3 tasks
@peterdudfield peterdudfield mentioned this pull request Oct 28, 2024
@peterdudfield peterdudfield deleted the copy-cache branch October 28, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant