Utkarsh/issue 186

[Sigma-Verma]

Made cache removal safer by using a lock to avoid repeated checks

Pull Request

Description

Enhanced thread safety by consolidating cache removal logic within a lock, preventing redundant iterations and ensuring consistent access to shared data.

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have checked my code and corrected any misspellings

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: pv_site_api/cache.py

Function	Unhandled Issue
remove_old_cache	RuntimeError: dictionary changed size during iteration /sites/{site_uuid}/pv_fo... Event Count: 4
remove_old_cache	RuntimeError: dictionary changed size during iteration /sites/pv_... Event Count: 1

---

_{Did you find this useful? React with a 👍 or 👎}

[peterdudfield]

Thanks @Sigma-Verma for this.

Do you mind fixing the linting, see CI?

This seems a really good way to do it, with thread locking. Do you know how this works if two calls to the api are made very close to each other? Does this then slow down the second one? Perhaps this is the only way to do it?

Perhaps there's a speed up here, where we check if these items are cache locked, and if so carry on and do nothing

[Sigma-Verma]

hey can you guide me on how to fix the Linting ?
and for the question about two very close calls,
i added a catch entry removal check
If no entries need to be removed , it will skip the locking process

[peterdudfield]

hey can you guide me on how to fix the Linting ? and for the question about two very close calls, i added a catch entry removal check If no entries need to be removed , it will skip the locking process

See errors in the github actinos and fix manually

or do make format

[peterdudfield]

is this identented correctly?

[peterdudfield]

Also, do you mind incorporating #199?

[peterdudfield]

could you include the .copy() that i added please

[peterdudfield]

Thank you for this, just a small lint change,