Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for sdswrf and sdlwrf #187

Merged
merged 12 commits into from
Oct 15, 2024
Merged

Fix for sdswrf and sdlwrf #187

merged 12 commits into from
Oct 15, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 15, 2024 •
edited
Loading

Pull Request

Description

  • put test back in
  • same error as we see in production on 0.5.27
  • rename variables if there

Helps with #185

How Has This Been Tested?

Ci tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield mentioned this pull request Oct 15, 2024
Closed
@peterdudfield peterdudfield changed the title Put test back in Fix for sdswrf and Oct 15, 2024
@peterdudfield peterdudfield changed the title Fix for sdswrf and Fix for sdswrf and sdlwrf Oct 15, 2024
@peterdudfield peterdudfield requested a review from devsjc October 15, 2024 15:26
@devsjc devsjc merged commit bd12126 into main Oct 15, 2024
12 checks passed
@devsjc devsjc deleted the put-test-back-in branch October 15, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc