Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.27 #185

Closed
peterdudfield opened this issue Oct 4, 2024 · 14 comments
Closed

0.5.27 #185

peterdudfield opened this issue Oct 4, 2024 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@peterdudfield
Copy link
Contributor

openclimatefix/pv-site-production#91

Pv-site-production didnt seem to work tieh 0.5.27, but was fine with 0.5.25. Im not sure what the issue is to be honest

@peterdudfield peterdudfield added the bug Something isn't working label Oct 4, 2024
@peterdudfield
Copy link
Contributor Author

Nor does pvnet

@peterdudfield
Copy link
Contributor Author

I this could be related to the variables not be renamed proberly

Screenshot 2024-10-04 at 14 38 43

@peterdudfield
Copy link
Contributor Author

Could be good idea to pin requirements to make sure this doesnt happy

@devsjc
Copy link
Collaborator

devsjc commented Oct 4, 2024

I'll see if I can pin down whether its something that has changed in the cfgrib or eccodes library, as they are what decode the grib messages - I can't think of any changes in the repository itself that would lead to this otherwise, that test file and the reading code hasn't been touched in a long time! If so, as you say, an explicit version pin should resolve it.

@peterdudfield
Copy link
Contributor Author

Was the idea to pin the requirments, similar to your local to check it works ok?

@devsjc
Copy link
Collaborator

devsjc commented Oct 15, 2024

It was, see #186

@devsjc
Copy link
Collaborator

devsjc commented Oct 15, 2024

Fixed with #186

@devsjc devsjc closed this as completed Oct 15, 2024
@peterdudfield peterdudfield reopened this Oct 15, 2024
@peterdudfield
Copy link
Contributor Author

Sorry im still seeing issues with 0.5.27

@peterdudfield
Copy link
Contributor Author

we should put this test back in -

@unittest.skip("Broken on github ci")

@peterdudfield
Copy link
Contributor Author

Im just trying to run the docker file made on main to see if we have the same issue

@peterdudfield
Copy link
Contributor Author

started a draft PR - #187

@peterdudfield
Copy link
Contributor Author

Annoying thing is the test works fine locally, but doesnt work in the CI and docker file e.t.c.

i might try builind the nwp docker file locally, and run the test in that

@peterdudfield
Copy link
Contributor Author

could be related to ecmwf/cfgrib#385?

@peterdudfield
Copy link
Contributor Author

Looks like it is solved in 0.5.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants