Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap functions into app.py and add .gitignore for unnecessary files #15

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

siddharth7113
Copy link
Contributor

Pull Request

Description

This PR wraps the forecast-related functionalities into a single app.py script and adds a .gitignore file to the repository to prevent tracking unnecessary files.

  • app.py: Implements modular functions (get_forecast, format_forecast, save_forecast) to fetch, format, and save NESO solar forecast data.
  • .gitignore: Ensures unnecessary files such as Python bytecode, test cache, build artifacts, and logs are ignored.

Fixes: #6 and #14

How Has This Been Tested?

  1. Ran the app.py script manually to verify the following:
    • Forecast data is fetched correctly using placeholder resource IDs.
  2. Verified that the .gitignore prevents unnecessary files from being tracked.
  • Yes

If your changes affect data processing, have you plotted any changes? i.e., have you done a quick sanity check?

  • Yes
    • Logs were reviewed to ensure steps executed correctly.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works (tests for .gitignore are implicit)
  • I have checked my code and corrected any misspellings

app.py Outdated Show resolved Hide resolved
@siddharth7113 siddharth7113 marked this pull request as ready for review December 4, 2024 03:43
@peterdudfield
Copy link
Contributor

Happy to merge?

@peterdudfield peterdudfield merged commit 9e5e379 into openclimatefix:main Dec 5, 2024
@siddharth7113 siddharth7113 deleted the 6-wrap-app branch December 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants