Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regridding #150

Merged
merged 13 commits into from
Dec 2, 2024
Merged

add regridding #150

merged 13 commits into from
Dec 2, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 29, 2024 •
edited
Loading

Pull Request

Description

Add regridding for mo_global data

Changes reuslts from

Screenshot 2024-12-01 at 11 37 42

to

Screenshot 2024-12-01 at 11 42 42

How Has This Been Tested?

  • CI tests

  • ran it locally,

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from Sukh-P November 29, 2024 15:39
@peterdudfield peterdudfield mentioned this pull request Nov 29, 2024
Closed
@peterdudfield peterdudfield marked this pull request as ready for review December 1, 2024 18:26
Sukh-P
Sukh-P reviewed Dec 2, 2024
View reviewed changes
india_forecast_app/models/pvnet/utils.py
is_ecmwf = "ecmwf" in source_nwp_path.lower()

if is_ecmwf:
if nwp_config.source == "ecmwf":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a separate PR but it would be good to do this for ECMWF as well as there is also a difference in spatial resolution between training and live for it, although it is worth noting that I think we the current HF config files we use it will error since we have hacked them to work and would need to change them back to the original number of pixels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i was thinking a seperate PR for ECMWF stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in #153

@peterdudfield peterdudfield merged commit d1e9936 into main Dec 2, 2024
3 checks passed
@peterdudfield peterdudfield deleted the regrid branch December 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P