Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/adjuster minutes #138

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Issue/adjuster minutes #138

merged 3 commits into from
Nov 26, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

  • add method to choose how we group the adjuster values by.
  • set ad sites to use 15 minutes
  • keep ruvnl sites to be 60 minutes grouping due to sprase data sometimes, and wind needing to be smoothed

#136

How Has This Been Tested?

  • CI tests
  • added a test
  • ran locally for ruvnl

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 26, 2024 14:40
@peterdudfield peterdudfield requested a review from Sukh-P November 26, 2024 14:40
@peterdudfield peterdudfield merged commit fbd3f04 into main Nov 26, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/adjuster-minutes branch November 26, 2024 15:02
@peterdudfield
Copy link
Contributor Author

Version 1.1.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P