Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests failing #230

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Fix tests failing #230

merged 5 commits into from
Jul 1, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jul 1, 2024 •
edited
Loading

Pull Request

Description

Upgrade test to work for Tabnet

#229

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title Update pyproject.toml #229 Fix tests failing Jul 1, 2024
@peterdudfield peterdudfield mentioned this pull request Jul 1, 2024
Closed
5 tasks
@peterdudfield peterdudfield requested a review from Sukh-P July 1, 2024 14:40
Sukh-P
Sukh-P approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I understand the fix but the tests are passing, nice one!

@peterdudfield peterdudfield merged commit f362649 into main Jul 1, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/torch-2.3.0 branch July 1, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @Sukh-P