Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script config parameters #231

Closed
wants to merge 14 commits into from
Closed

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jul 1, 2024

Pull Request

Description

Updating the config parameters to the dataloader in the save_concurrent_batches script to match the structure in the config example files and the save_batches script.

Also updated an incorrect install command for ocf_datapipes

How Has This Been Tested?

Ran the script and created some concurrent batches.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor

btw tests may fail until this is merged - #230

Sukhil Patel and others added 11 commits July 1, 2024 15:40
* Update pyproject.toml #229

* pin

* use pytorch_lightning in pyproject.toml

* fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Sukh-P Sukh-P closed this Jul 2, 2024
@Sukh-P Sukh-P deleted the update-script-config-parameters branch July 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants