feat: elaborate TODOs (#227) #773
Annotations
20 warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1, actions/setup-node@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Build .NET Core Authentication Authority Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Fakes/OpenActive.FakeDatabase.NET/OpenActive.FakeDatabase.NET.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
Unreachable code detected [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Fakes/OpenActive.FakeDatabase.NET/OpenActive.FakeDatabase.NET.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Authentication Authority Reference Implementation
Unreachable code detected [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/Examples/BookingSystem.AspNetCore.IdentityServer/BookingSystem.AspNetCore.IdentityServer.csproj]
|
Build .NET Core Booking Server Reference Implementation
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Avoid empty interfaces [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Exceptions should be public [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Consider calling ConfigureAwait on the awaited task [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Build .NET Core Booking Server Reference Implementation
Consider calling ConfigureAwait on the awaited task [/home/runner/work/OpenActive.Server.NET/OpenActive.Server.NET/server/OpenActive.Server.NET/OpenActive.Server.NET.csproj]
|
Set up job
1s
1s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Build bacongobbler/azure-blob-storage-upload@v1.2.0
18s
18s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Checkout OpenActive.Server.NET
1s
1s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Use matching coverage/* branch in OpenActive Test Suite
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Checkout OpenActive Test Suite
1s
1s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Setup .NET Core SDK 3.1.419
11s
11s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Setup Node.js 18.17.1
3s
3s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Install OpenActive.Server.NET dependencies
6s
6s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Build .NET Core Authentication Authority Reference Implementation
5s
5s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Start .NET Core Authentication Authority Reference Implementation
5s
5s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Build .NET Core Booking Server Reference Implementation
4s
4s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Start .NET Core Booking Server Reference Implementation
4s
4s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Install OpenActive Test Suite
47s
47s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Run OpenActive Integration Tests in random mode
30m 9s
30m 9s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Upload test output for random mode as artifact
41s
41s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Deploy conformance certificate to Azure Blob Storage (master branch for 'all-features' profile in controlled mode only)
5s
5s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Post Checkout OpenActive Test Suite
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Post Checkout OpenActive.Server.NET
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Complete job
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Loading