feat: elaborate TODOs (#227) #773
Annotations
2 errors and 15 warnings
Build .NET Framework Reference Implementation:
Examples/BookingSystem.AspNetFramework/Feeds/SessionsFeeds.cs#L1
Feature 'static local functions' is not available in C# 7.3. Please use language version 8.0 or greater. [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Examples\BookingSystem.AspNetFramework\BookingSystem.AspNetFramework.csproj]
|
Build .NET Framework Reference Implementation
Process completed with exit code 1.
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v1, microsoft/setup-msbuild@v1.0.2, NuGet/setup-nuget@v1.0.5, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1, microsoft/setup-msbuild@v1.0.2, NuGet/setup-nuget@v1.0.5, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Setup NuGet
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Setup MSBuild path
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Upload test output for random mode as artifact
No files were found with the provided path: ./tests/output/. No artifacts will be uploaded.
|
Build .NET Framework Reference Implementation
The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\Fakes\OpenActive.FakeDatabase.NET\OpenActive.FakeDatabase.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L1
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Avoid empty interfaces [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Exceptions should be public [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message). [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs#L1
Add the following constructor to SilentRollbackException: public SilentRollbackException(string message, Exception innerException). [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/OpenBookingHelper/Async/AsyncDuplicateLock.cs#L1
Call System.IDisposable.Dispose on object created by 'new SemaphoreSlim(1, 1)' before all references to it are out of scope. [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L1
Member CalculateIdempotencyKey does not access instance data and can be marked as static (Shared in VisualBasic) [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/OpenBookingHelper/Stores/IdempotencyStore.cs#L1
In externally visible method 'string IdempotencyStore.CalculateIdempotencyKey(OrderIdComponents orderId, string orderJson)', validate parameter 'orderId' is non-null before using it. If appropriate, throw an ArgumentNullException when the argument is null or add a Code Contract precondition asserting non-null argument. [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Build .NET Framework Reference Implementation:
OpenActive.Server.NET/CustomBookingEngine/CustomBookingEngine.cs#L1
Consider calling ConfigureAwait on the awaited task [D:\a\OpenActive.Server.NET\OpenActive.Server.NET\server\OpenActive.Server.NET\OpenActive.Server.NET.csproj]
|
Set up job
4s
4s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Checkout OpenActive.Server.NET
7s
7s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Use matching coverage/* branch in OpenActive Test Suite
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Checkout OpenActive Test Suite
12s
12s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Setup Node.js 18.17.1
15s
15s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Setup MSBuild path
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Setup NuGet
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Install OpenActive.Server.NET dependencies
1m 43s
1m 43s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Build .NET Framework Reference Implementation
16s
16s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Deploy .NET Framework Reference Implementation to folder
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Start .NET Framework Reference Implementation from folder (using IIS Express)
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Install OpenActive Test Suite
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Run OpenActive Integration Tests in random mode
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Upload test output for random mode as artifact
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Post Checkout OpenActive Test Suite
2s
2s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Post Checkout OpenActive.Server.NET
2s
2s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Complete job
0s
0s
Error:
This step has been truncated due to its large size. Download the full logs from the menu
once the workflow run has completed.
Loading