Propagate exit code from the run() and do_() commandline methods #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbc
reviewed
Apr 8, 2024
Comment on lines
+565
to
568
| sys.exit(exit_code) | ||
| else: | ||
| args = None | ||
| return cmd, args |
There was a problem hiding this comment.
Just wanted to point out that the code inside the if run: block would never reach the return cmd, args statement, not sure if that's expected.
There was a problem hiding this comment.
Thanks for checking. Yes, it is expected. run=False is used during tests to check the command and arguments that would be normally executed.
dmach
force-pushed
the
cmd-propagate-exit-code
branch
9 times, most recently
from
aaee075 to
7bdb5e7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dmach
force-pushed
the
cmd-propagate-exit-code
branch
from
e013d9c to
201b302
Compare
This was a bad API, command handlers should return None or an exit code. Anything that returns an actual value belongs to the library instead.
dmach
force-pushed
the
cmd-propagate-exit-code
branch
from
201b302 to
2b3e04e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1532