Skip to content

Commit

Permalink
Fix do_createrequest() function to return None instead of request id
Browse files Browse the repository at this point in the history
This was a bad API, command handlers should return None or an exit code.
Anything that returns an actual value belongs to the library instead.
  • Loading branch information
dmach committed Apr 9, 2024
1 parent f0013b3 commit aaee075
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion osc/commandline.py
Original file line number Diff line number Diff line change
Expand Up @@ -2828,7 +2828,6 @@ def do_createrequest(self, subcmd, opts, *args):
for srid in supersede:
change_request_state(apiurl, srid, 'superseded',
f'superseded by {rid}', rid)
return rid

@cmdln.option('-m', '--message', metavar='TEXT',
help='specify message TEXT')
Expand Down

0 comments on commit aaee075

Please sign in to comment.