Fix span option typo in SDK span End, and WithAttributes only being available on span start #6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
XSAM,
dashpole and
pellared
as code owners
petenewcomb
reviewed
Nov 27, 2024
dmathieu
changed the title
|
I have also updated the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6006 +/- ##
=======================================
- Coverage 82.1% 82.1% -0.1%
=======================================
Files 273 273
Lines 23652 23652
=======================================
- Hits 19437 19436 -1
- Misses 3870 3871 +1
Partials 345 345 |
pellared
approved these changes
Nov 27, 2024
MrAlias
approved these changes
Nov 27, 2024
|
Merging as a trivial update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.