Skip to content

Commit

Permalink
Fix span option typo in SDK span End, and WithAttributes only being a…
Browse files Browse the repository at this point in the history
…vailable on span start (#6006)
  • Loading branch information
dmathieu authored Nov 27, 2024
1 parent 652588d commit bab2460
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sdk/trace/span.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,8 @@ func truncate(limit int, s string) string {
// End ends the span. This method does nothing if the span is already ended or
// is not being recorded.
//
// The only SpanOption currently supported is WithTimestamp which will set the
// end time for a Span's life-cycle.
// The only SpanEndOption currently supported are [trace.WithTimestamp], and
// [trace.WithStackTrace].
//
// If this method is called while panicking an error event is added to the
// Span before ending it and the panic is continued.
Expand Down
2 changes: 1 addition & 1 deletion trace/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ var _ SpanStartEventOption = attributeOption{}

// WithAttributes adds the attributes related to a span life-cycle event.
// These attributes are used to describe the work a Span represents when this
// option is provided to a Span's start or end events. Otherwise, these
// option is provided to a Span's start event. Otherwise, these
// attributes provide additional information about the event being recorded
// (e.g. error, state change, processing progress, system event).
//
Expand Down

0 comments on commit bab2460

Please sign in to comment.