-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lychee new cache-exclude-status option and upgrade lychee-action #6323
Use lychee new cache-exclude-status option and upgrade lychee-action #6323
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6323 +/- ##
=====================================
Coverage 66.8% 66.8%
=====================================
Files 193 193
Lines 15580 15580
=====================================
+ Hits 10408 10414 +6
+ Misses 4881 4877 -4
+ Partials 291 289 -2 |
can we somehow get rid of:
or does it mean that it still does not work as expected? |
I think that means it works as expected. We currently cache 429s, and this PR uses the cache. |
I am just not sure if the cache would be ever renewed given the cached error. Still, not a blocker. I think we can merge this PR. |
The cache has a finite duration. It is renewed every day. |
Lychee's
cache-exclude-status
option has shipped. So we can use it rather than ignore 429s.This also upgrades lychee-action to 2.1.0. We had to revert that in #6229 due to a regression, which was fixed in lycheeverse/lychee-action#255