Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lychee CI failure: 429 too many requests #6183

Closed
MrAlias opened this issue Oct 3, 2024 · 2 comments
Closed

Lychee CI failure: 429 too many requests #6183

MrAlias opened this issue Oct 3, 2024 · 2 comments
Assignees
@dmathieu
Milestone
v1.33.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 3, 2024 

### Errors in ./RELEASING.md

* [429] [https://github.com/open-telemetry/opentelemetry-go/commits/main](https://github.com/open-telemetry/opentelemetry-go/commits/main) | Failed: Network error: Too Many Requests

Example: https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/11151936706/job/30996462798?pr=6002
@dmathieu
Copy link
Member

dmathieu commented Oct 4, 2024

The two fixes here could be to get lycheeverse/lychee#1403 to move forward, so a links check that fails would still update the cache with URLs that succeeded, making retries only fetch the previously failing URLs, and fixing rate limit issues.

If we can't get that moving, we'll have to disable the links check temporarily, or have it consider 429s as success.

@dmathieu dmathieu mentioned this issue Oct 7, 2024
Merged
@MrAlias MrAlias mentioned this issue Oct 8, 2024
Merged
dmathieu added a commit that referenced this issue Oct 10, 2024
@dmathieu
Temporarily consider 429s as success in links check (#6210)
60905d6 
This considers 429s as a success, until we can get lychee to cache
success requests even if there's a failure.
This should only be a temporary measure. But ignoring one status code
seems better than entirely disabling the check.

Related: #6183.
@dmathieu
Copy link
Member

This has been fixed in #6323

@pellared pellared added this to the v1.33.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmathieu dmathieu

Labels
None yet
Projects
None yet
Milestone
v1.33.0
Development

No branches or pull requests
3 participants
@dmathieu @pellared @MrAlias