Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update lycheeverse/lychee-action action to v2" #6229

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

dmathieu
Copy link
Member

Reverts #6220

lychee-action has a regression in v2, where it deletes the config file, and we therefore try checking links for templates that shouldn't be checked.
See lycheeverse/lychee-action#255

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 10, 2024
@dmathieu dmathieu marked this pull request as ready for review October 10, 2024 08:33
@dmathieu dmathieu requested a review from a team as a code owner October 10, 2024 08:33
@dmathieu
Copy link
Member Author

Merging this with a single review as it's a revert, and our CI has been failing for way too long.

@dmathieu dmathieu merged commit 20e45af into main Oct 11, 2024
26 checks passed
@dmathieu dmathieu deleted the revert-6220-renovate/lycheeverse-lychee-action-2.x branch October 11, 2024 07:41
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 14, 2024
pellared pushed a commit that referenced this pull request Nov 14, 2024
…6323)

Lychee's `cache-exclude-status` option has shipped. So we can use it
rather than ignore 429s.
This also upgrades lychee-action to 2.1.0. We had to revert that in
#6229 due
to a regression, which was fixed in
lycheeverse/lychee-action#255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants