Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update lycheeverse/lychee-action action to v2 #6220

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024

This PR contains the following updates:

Package Type Update Change
lycheeverse/lychee-action action major v1.10.0 -> v2.0.0

Release Notes

lycheeverse/lychee-action (lycheeverse/lychee-action)

v2.0.0: Version 2.0.0

Compare Source

Breaking Changes

Note: This release improves the action's robustness by changing default behaviors. Changes are only required if you want to opt out of the new failure conditions. Most users won't need to modify their existing configurations.

Fail pipeline on error by default

We've changed the default behavior: pipelines will now fail on broken links automatically. This addresses user feedback that not failing on broken links was unexpected (see issue #​71).

What you need to do:

  • Update to version 2 of this action to apply this change.
  • Users of the lychee-action@master branch don't need to make any changes, as fail: true has been the default there for a while.
  • If you prefer the old behavior, explicitly set fail to false when updating:
- name: Link Checker
  id: lychee
  uses: lycheeverse/lychee-action@v2
  with:
    fail: false  # Don't fail action on broken links
Fail pipeline if no links were found

Similar to the above change, we now fail the pipeline if no links are found during a run. This helps warn users about potential configuration issues.

What you need to do:

  • If you expect links to be found in your pipeline run, you don't need to do anything.
  • If you expect no links in your pipeline run, you can opt out like this:
- name: Link Checker
  id: lychee
  uses: lycheeverse/lychee-action@v2
  with:
    failIfEmpty: false  # Don't fail action if no links were found

For a more detailed description of the technical aspects behind these changes, please see the full changelog below.

What's Changed

New Contributors

Full Changelog: lycheeverse/lychee-action@v1...v1.11.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner October 8, 2024 13:34
@renovate renovate bot added dependencies Pull requests that update a dependency file Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (cb1af8a) to head (8a89eca).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6220   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        194     194           
  Lines      12692   12692           
=====================================
+ Hits        8512    8514    +2     
+ Misses      3902    3901    -1     
+ Partials     278     277    -1     

see 1 file with indirect coverage changes

@dmathieu
Copy link
Member

dmathieu commented Oct 8, 2024

Errors in ./zpages/internal/templates/summary.html

Error: R] file:///home/runner/work/opentelemetry-go-contrib/opentelemetry-go-contrib/zpages/internal/templates/%7B%7B$a%7D%7D | Failed: Cannot find file

Looks like this error should be fixed first.

@renovate renovate bot force-pushed the renovate/lycheeverse-lychee-action-2.x branch 2 times, most recently from b124e06 to 17967dd Compare October 9, 2024 07:36
@renovate renovate bot force-pushed the renovate/lycheeverse-lychee-action-2.x branch from 17967dd to 8a89eca Compare October 9, 2024 13:43
@MrAlias MrAlias merged commit c13ee4b into main Oct 10, 2024
24 of 26 checks passed
@MrAlias MrAlias deleted the renovate/lycheeverse-lychee-action-2.x branch October 10, 2024 06:38
@dmathieu
Copy link
Member

This upgrade is broken, because lychee-action has a regression where it deletes the config file.
See lycheeverse/lychee-action#255

dmathieu added a commit that referenced this pull request Oct 10, 2024
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
dmathieu added a commit that referenced this pull request Oct 11, 2024
…6229)

Reverts #6220

lychee-action has a regression in v2, where it deletes the config file,
and we therefore try checking links for templates that shouldn't be
checked.
See lycheeverse/lychee-action#255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants