Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy as latest #1020

Merged
merged 7 commits into from
Nov 7, 2024
+9 −6
Merged

Jazzy as latest #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6c3aadd
Jazzy as latest
aaronchongth Oct 23, 2024
4add4d5
Fix yaml
aaronchongth Oct 23, 2024
b43c79b
Update docs
aaronchongth Oct 23, 2024
0f3e247
Use formatting for api-server image tag
aaronchongth Oct 23, 2024
39a65b7
Revert nightly push
aaronchongth Oct 23, 2024
942fc7a
Using nightly
aaronchongth Oct 29, 2024
d8ad8c0
Revert schedule
aaronchongth Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
push: true
build-args: |
ROS_DISTRO=${{ matrix.ros_distribution }}
tags: ghcr.io/${{ github.repository }}/minimal-rmf:${{ matrix.ros_distribution }}
tags: ghcr.io/${{ github.repository }}/minimal-rmf:${{ matrix.ros_distribution }}-nightly
context: .github/minimal-rmf
build-dashboard-image:
needs: build-minimal-rmf-docker-images
Expand Down Expand Up @@ -76,8 +76,10 @@ jobs:
push: true
build-args: |
ROS_DISTRO=${{ matrix.ros_distribution }}
BASE_IMAGE=ghcr.io/${{ github.repository }}/minimal-rmf:${{ matrix.ros_distribution }}
tags: ghcr.io/${{ github.repository }}/api-server:${{ matrix.ros_distribution }}
BASE_IMAGE=ghcr.io/${{ github.repository }}/minimal-rmf:${{ matrix.ros_distribution }}-nightly
tags: |
ghcr.io/${{ github.repository }}/api-server:${{ matrix.ros_distribution }}-nightly
${{ matrix.ros_distribution == 'jazzy' && format('ghcr.io/{0}/api-server:latest', github.repository) || null}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this is a nightly ci, so we should tag them as jazzy-nightly and rolling-nightly instead. jazzy and rolling should point to the latest released version.

context: .github/api-server
# dashboard-e2e:
# strategy:
Expand Down
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,17 @@ docker run \
> **Note**
> The values provided for `RMF_SERVER_URL` and `TRAJECTORY_SERVER_URL` are default values when running the API server and `rmf_demos`, and can be modified to suit different setups.

Start the API server with host network access, and set up the correct `ROS_DOMAIN_ID` and ROS 2 RMW implementation that will be used in the rest of the Open-RMF system. The API server will use the default port at `localhost:8000`.
Start the API server with host network access, and set up the correct `ROS_DOMAIN_ID` and ROS 2 RMW implementation (The images currently have `rmw_fastrtps_cpp` and `rmw_cyclonedds_cpp` installed and supported) that will be used in the rest of the Open-RMF system. The API server will use the default port at `localhost:8000`.

```bash
docker run \
--network host -it --rm \
-e ROS_DOMAIN_ID=<ROS_DOMAIN_ID> \
-e RMW_IMPLEMENTATION=<RMW_IMPLEMENTATION> \
ghcr.io/open-rmf/rmf-web/api-server:jazzy
ghcr.io/open-rmf/rmf-web/api-server:latest

# For ROS 2 Rolling, use ghcr.io/open-rmf/rmf-web/api-server:rolling
# The latest tag would be the same as jazzy
# For ROS 2 Rolling, use ghcr.io/open-rmf/rmf-web/api-server:rolling-nightly
```

> **Note**
Expand Down