Jazzy as latest #1020
Merged
Jazzy as latest #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
koonpeng
approved these changes
Oct 23, 2024
koonpeng
requested changes
Oct 23, 2024
| tags: ghcr.io/${{ github.repository }}/api-server:${{ matrix.ros_distribution }} | ||
| tags: | | ||
| ghcr.io/${{ github.repository }}/api-server:${{ matrix.ros_distribution }} | ||
| ${{ matrix.ros_distribution == 'jazzy' && format('ghcr.io/{0}/api-server:latest', github.repository) || null}} |
There was a problem hiding this comment.
I just realized that this is a nightly ci, so we should tag them as jazzy-nightly and rolling-nightly instead. jazzy and rolling should point to the latest released version.
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
|
Good point, I've opened #1022 to as a reminder to set up that workflow to be triggered by releases |
koonpeng
approved these changes
Nov 4, 2024
|
Will merge this after #1007, since conflicts will only be in 2 files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
jazzyaslatestas wellSelf-checks