Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming nginx/fulltest-provider -> nginx/fulltest & delete old fulltest dir. #249

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

bhess
Copy link
Member

@bhess bhess commented Nov 13, 2023

As suggested in #245 (comment):

Deletes the old OpenSSL 1.1.1 nginx "fulltest" and renames the oqs-provider based "fulltest-provider" to "fulltest".

@bhess bhess force-pushed the bhe-fulltest-rename branch from 8d63196 to 8938369 Compare January 17, 2024 09:31
@bhess bhess requested a review from baentsch January 17, 2024 09:32
nginx/fulltest/README.md Outdated Show resolved Hide resolved
nginx/fulltest/README.md Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually LGTM -- two nits and one question regarding Chromium support, though.

@bhess
Copy link
Member Author

bhess commented Jan 17, 2024

Thanks @baentsch, will follow up with a PR on #256.

@bhess bhess merged commit 10fd016 into main Jan 17, 2024
15 checks passed
@bhess bhess deleted the bhe-fulltest-rename branch January 18, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants