Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Chromium usage instructions [skip ci] #245

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Nov 2, 2023

As per #243 (reply in thread). Feedback welcome @pi-314159 .

@pi-314159
Copy link
Member

LGTM. A small suggestion:

Execute ./chrome in the directory...

  Execute `./chrome` or `chrome.exe` in the directory...

When we edit README-Linux and README-Windows next time, we'll add notes about how to create a installer on Windows and how to pack the build directory on Linux.

@baentsch baentsch marked this pull request as ready for review November 3, 2023 07:48
@baentsch
Copy link
Member Author

baentsch commented Nov 3, 2023

@bhess, this contains an update that may be worth while deploying to the test server.

Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baentsch.
However, for the test server update, the following page would need to be updated:
https://github.com/open-quantum-safe/oqs-demos/blob/main/nginx/fulltest-provider/index-template.

(The version in the fulltest folder is deprecated / used to build against the old OpenSSL 1.1.1 fork)

@baentsch
Copy link
Member Author

baentsch commented Nov 3, 2023

The version in the fulltest folder is deprecated / used to build against the old OpenSSL 1.1.1 fork

Thanks for this correction. Now fixed. What about removing the old directory then?

@bhess
Copy link
Member

bhess commented Nov 3, 2023

Ok with me to delete the old folder.

@baentsch
Copy link
Member Author

baentsch commented Nov 3, 2023

Ok with me to delete the old folder.

Looking at this from a code-origin traceability perspective deleting fulltest-provider seems more correct: Would you want to do such PR, @bhess such as to have your code changes properly attributed to you?

@baentsch baentsch merged commit 91503b4 into main Nov 3, 2023
1 check passed
@baentsch baentsch deleted the mb-chromiumusage branch November 3, 2023 15:30
@bhess
Copy link
Member

bhess commented Nov 13, 2023

Added a PR #249 for deleting the old directory and renaming fulltest-provider.

I also deployed the update from this PR at test.openquantumsafe.org. A test run works fine.
However @baentsch, I noticed that the "0.9.0" tag is missing on dockerhub for openquantumsafe/curl, which is used for the test run. Could you please publish this tag? The ":latest" tag isn't compatible anymore because of the recent HQC update in liboqs.

@baentsch
Copy link
Member Author

Oops -- looks like this question slipped my attention. It should now be addressed as/when #257 gets resolved. The point itself is moot by now given we are about to completely eliminate references to 0.9.0/0.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants