-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Chromium usage instructions [skip ci] #245
Conversation
LGTM. A small suggestion:
When we edit README-Linux and README-Windows next time, we'll add notes about how to create a installer on Windows and how to pack the build directory on Linux. |
@bhess, this contains an update that may be worth while deploying to the test server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @baentsch.
However, for the test server update, the following page would need to be updated:
https://github.com/open-quantum-safe/oqs-demos/blob/main/nginx/fulltest-provider/index-template.
(The version in the fulltest folder is deprecated / used to build against the old OpenSSL 1.1.1 fork)
Thanks for this correction. Now fixed. What about removing the old directory then? |
Ok with me to delete the old folder. |
Looking at this from a code-origin traceability perspective deleting |
Added a PR #249 for deleting the old directory and renaming fulltest-provider. I also deployed the update from this PR at test.openquantumsafe.org. A test run works fine. |
Oops -- looks like this question slipped my attention. It should now be addressed as/when #257 gets resolved. The point itself is moot by now given we are about to completely eliminate references to 0.9.0/0.9.1. |
As per #243 (reply in thread). Feedback welcome @pi-314159 .