[GPU] Address clang-tidy complaints #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:gpu-intel
petercad
approved these changes
Jan 16, 2025
echeresh
approved these changes
Jan 16, 2025
dzarukin
approved these changes
Jan 17, 2025
| @@ -553,7 +553,8 @@ class layout_t { | |||
| b_str.append(1, '*'); | |||
| } | |||
| } | |||
| ret = b_str + ret; | |||
| b_str += ret; | |||
| std::swap(ret, b_str); | |||
There was a problem hiding this comment.
Was it a bug? The new sequence doesn't seem to do what it was doing before...
There was a problem hiding this comment.
b_str is destroyed immediately after this, so we don't care what happens to it. The effect on ret should be the same. I could replace the swap with ret = std::move(b_str) if it is clearer? Visually that change looks like it would be better as the original, so the swap is there to help prevent someone coming along later and trying to undo the change.
atkassen
force-pushed
the
akassen/clang-tidy-gpu
branch
from
60e94cb to
c377734
Compare
hidefromkgb
reviewed
Jan 17, 2025
atkassen
force-pushed
the
akassen/clang-tidy-gpu
branch
from
c377734 to
e1d1ebe
Compare
hidefromkgb
approved these changes
Jan 18, 2025
atkassen
force-pushed
the
akassen/clang-tidy-gpu
branch
from
e1d1ebe to
bece593
Compare
|
make test |
atkassen
force-pushed
the
akassen/clang-tidy-gpu
branch
from
bece593 to
5d22ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most of the clang-tidy hits in MFDNN-13007. Missing are fixes for macro warnings and emulation.hpp class name styling.
make testandmake test_benchdnn_*) pass locally for each commit?