Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audience to the client_options #179

Merged

Commits on May 24, 2024

  1. Add audience to the client_options

    I've come across an issue where the `identifier` wasn't equal to the `audience` in the token.
    This resulted in verification errors because currently it will verify the `aud` against the `identifier` if no `audience` is specified.
    
    In this PR, I introduced the `audience` as `client_options` and will pass this along in the `verify!` of the `decoded_id_token` so the openid_connect gem [can handle the expected audience](https://github.com/nov/openid_connect/blob/e1eb8ea962af43752b1aed2c1063a3e24f96c5bc/lib/openid_connect/response_object/id_token.rb#L30-L32)
    manuelvanrijn committed May 24, 2024
    Configuration menu
    Copy the full SHA
    43407b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    94c649a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Update README.md

    Co-authored-by: Roger Meier <[email protected]>
    manuelvanrijn and bufferoverflow authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    38ae821 View commit details
    Browse the repository at this point in the history