Add audience to the client_options
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've come across an issue where the `identifier` wasn't equal to the `audience` in the token. This resulted in verification errors because currently it will verify the `aud` against the `identifier` if no `audience` is specified. In this PR, I introduced the `audience` as `client_options` and will pass this along in the `verify!` of the `decoded_id_token` so the openid_connect gem [can handle the expected audience](https://github.com/nov/openid_connect/blob/e1eb8ea962af43752b1aed2c1063a3e24f96c5bc/lib/openid_connect/response_object/id_token.rb#L30-L32)
|
@stanhu @bufferoverflow just a friendly ping 😄 Would you have time to review this ? Thanks in advance! |
stanhu
reviewed
Jun 27, 2024
stanhu
reviewed
Jul 3, 2024
stanhu
reviewed
Jul 3, 2024
|
There are also Rubocop failures: https://github.com/omniauth/omniauth_openid_connect/actions/runs/9779345570/job/27001862614?pr=179 |
manuelvanrijn
force-pushed
the
introduce-audience-client-option
branch
from
124d76d
to
94c649a
Compare
stanhu
approved these changes
Jul 5, 2024
bufferoverflow
approved these changes
Jul 5, 2024
Co-authored-by: Roger Meier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across an issue where the
identifierwasn't equal to theaudiencein the token. This resulted in verification errors because currently it will verify theaudagainst theidentifierif noaudienceis specified.In this PR, I introduced the
audienceasclient_optionsand will pass this along in theverify!of thedecoded_id_tokenso the openid_connect gem can handle the expected audience