Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 1-Beginner/Personal-Skills/07-How-to-Optimize-Loops #9

Merged
merged 4 commits into from
Jan 12, 2021

Conversation

soheekim911
Copy link

작업 내용

PR 전 확인하기

  • PR(Pull Request) 전에 이슈를 먼저 생성하셨나요?
  • 중복된 작업을 한 PR 이 없나요?
  • Maintainer가 수정할 수 있도록 Allow edits from maintainers 항목을 체크하셨나요?
  • (번역 작업이라면) 파일 이름은 원래 파일과 같게 kr/ 폴더 밑에 위치해있나요?

Copy link
Owner

@ohahohah ohahohah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역에 참여해주셔서 감사합니다. 몇 가지 제안을 comment 로 남겨두었습니다. 고려해보시면 감사하겠습니다.

kr/1-Beginner/Personal-Skills/07-How-to-Optimize-Loops.md Outdated Show resolved Hide resolved
kr/1-Beginner/Personal-Skills/07-How-to-Optimize-Loops.md Outdated Show resolved Hide resolved
@ohahohah ohahohah changed the title Translate 1-Beginner/Personal-Skills/07-How-to-Optimize-Loops [WIP] Translate 1-Beginner/Personal-Skills/07-How-to-Optimize-Loops Jan 6, 2021
@ohahohah
Copy link
Owner

ohahohah commented Jan 6, 2021

@soheekim911 작업 중이실 때는 PR 앞에 [WIP] 키워드를 붙여주시면 구분이 가능합니다. 작업에 완료되시면 PR 제목 수정과 함께 comment 부탁드립니다.

@soheekim911 soheekim911 reopened this Jan 12, 2021
@soheekim911 soheekim911 changed the title [WIP] Translate 1-Beginner/Personal-Skills/07-How-to-Optimize-Loops Translate 1-Beginner/Personal-Skills/07-How-to-Optimize-Loops Jan 12, 2021
@soheekim911
Copy link
Author

작업이 끝나서 WIP를 지웠습니다!

@ohahohah ohahohah merged commit 2ab8b17 into ohahohah:kr Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants