Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field name resolution #715

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Missing field name resolution #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4cfc7d
missing field returned object
burnout87 Oct 8, 2024
ea3c446
extended test
burnout87 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cdci_data_analysis/analysis/drupal_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,6 +1559,7 @@
resolved_obj['RA'] = float(ra_tag.text)
resolved_obj['DEC'] = float(dec_tag.text)
resolved_obj['entity_portal_link'] = entities_portal_url.format(quoted_name)
resolved_obj['message'] = f'{name} successfully resolved'

Check warning on line 1562 in cdci_data_analysis/analysis/drupal_helper.py

View check run for this annotation

Codecov / codecov/patch

cdci_data_analysis/analysis/drupal_helper.py#L1562 

Added line #L1562 was not covered by tests

try:
Simbad.add_votable_fields("otype")
Expand Down
2 changes: 2 additions & 0 deletions tests/test_server_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2737,6 +2737,7 @@ def test_source_resolver(dispatcher_live_fixture_with_gallery, dispatcher_test_c
assert 'entity_portal_link' in resolved_obj
assert 'object_ids' in resolved_obj
assert 'object_type' in resolved_obj
assert 'message' in resolved_obj

assert resolved_obj['name'] == source_to_resolve.replace('_', ' ')
assert resolved_obj['entity_portal_link'] == dispatcher_test_conf_with_gallery["product_gallery_options"]["entities_portal_url"]\
Expand Down Expand Up @@ -2784,6 +2785,7 @@ def test_source_resolver_invalid_local_resolver(dispatcher_live_fixture_with_gal
assert 'entity_portal_link' in resolved_obj
assert 'object_ids' in resolved_obj
assert 'object_type' in resolved_obj
assert 'message' in resolved_obj

assert resolved_obj['name'] == source_to_resolve.replace('_', ' ')
assert resolved_obj['entity_portal_link'] == dispatcher_test_conf_with_gallery_invalid_local_resolver["product_gallery_options"]["entities_portal_url"]\
Expand Down
Loading