Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing field name resolution #715

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

burnout87
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.97%. Comparing base (1b0c79e) to head (ea3c446).

Files with missing lines Patch % Lines
cdci_data_analysis/analysis/drupal_helper.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   61.98%   61.97%   -0.01%     
==========================================
  Files          50       50              
  Lines        9114     9115       +1     
==========================================
  Hits         5649     5649              
- Misses       3465     3466       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87 burnout87 self-assigned this Oct 9, 2024
@burnout87 burnout87 marked this pull request as ready for review October 9, 2024 08:34
Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue behind?

@burnout87
Copy link
Collaborator Author

Is there an issue behind?

No, I didnt create it as it is basically the continuation of #712 , where I forgot to include a filed in the returned object

@burnout87
Copy link
Collaborator Author

Did you check this @volodymyrss ?

@burnout87 burnout87 merged commit a4068ea into master Oct 11, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants