Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameters #704

Merged
merged 23 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,5 @@ js9.fits
test-dispatcher-conf-with-gallery.yaml
tests/oda-ontology.ttl
tests/request_files
tests/local_request_files
tests/local_request_files
.lock_*
6 changes: 3 additions & 3 deletions cdci_data_analysis/analysis/instrument.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@
job.set_done()
if query_out.status_dictionary['status'] == 0:
query_out.set_done(message='dry-run',job_status=job.status)
query_out.set_instrument_parameters(self.get_parameters_list_as_json(prod_name=product_type))
query_out.set_instrument_parameters(self.get_parameters_list_jsonifiable(prod_name=product_type))

Check warning on line 438 in cdci_data_analysis/analysis/instrument.py

View check run for this annotation

Codecov / codecov/patch

cdci_data_analysis/analysis/instrument.py#L438

Added line #L438 was not covered by tests
else:
if query_out.status_dictionary['status'] == 0:
query_out = QueryOutput()
Expand Down Expand Up @@ -593,7 +593,7 @@
_query.show_parameters_list()
print("-------------")

def get_parameters_list_as_json(self, add_src_query=True, add_instr_query=True, prod_name=None):
def get_parameters_list_jsonifiable(self, add_src_query=True, add_instr_query=True, prod_name=None):

l=[{'instrumet':self.name}]
l.append({'prod_dict':self.query_dictionary})
Expand All @@ -608,7 +608,7 @@
if isinstance(_query, ProductQuery) and prod_name is not None and _query.name!=self.query_dictionary[prod_name]:
continue

l.append(_query.get_parameters_list_as_json(prod_dict=self.query_dictionary))
l.append(_query.get_parameters_list_jsonifiable(prod_dict=self.query_dictionary))

return l

Expand Down
Loading
Loading