-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional parameters #704
Optional parameters #704
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 62.06% 62.07% +0.01%
==========================================
Files 50 50
Lines 9139 9164 +25
==========================================
+ Hits 5672 5689 +17
- Misses 3467 3475 +8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Tests in integral plugin fail on metadata requests, an exception occurs in oda_api https://github.com/oda-hub/oda_api/blob/02e47e3670542e763f381364c4a87de99a2a9de9/oda_api/api.py#L920-L924 It may be fixed by adding other replaces (true->True), but I don't really understand why it's implemented like this anyway. Probably just legacy. |
Looks like legacy code, should be adjusted when possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why certain classes within the parameters
module are set as optional whereas others not?
Co-authored-by: Gabriele Barni <burnout87@users.noreply.github.com>
There are two parameters declared optional by default: All "normal" parameters are not optional by default. |
No description provided.