-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug for stage merging in last composite-metazoan #521
Comments
And more importantly, FBdv terms that have an xref in Uberon are not merged at all, e.g., FBdv:00000000, FBdv:00005317, etc. |
the problem is still present in the composite 28 August: [Term] |
Hi Chris, below another problem that also sounds to be a bug in composite-metazoan: Thank you for taking care of that as well! Anne [Term] |
More generally, I have a feeling that there are two concurrent imports of HsapDv and MmusDv, one that existed before the developmental-stage repository and that is now outdated, and one that is based on the current version of the repository, using the merged -uberon ontologies. Am I wrong? |
and also (sorry if I am mixing bugs!): id: HsapDv:0000094 |
Good news: latest release fixes HsapDv:0000001 Bad news: some classes are losing their axioms in composite-metazoan.obo, for example, 'late adult stage' loses it's part_of axiom (it retains a taxon GCI part_of, but not the generic part_of to post-juvenile). This appears to be in the owl2obo conversion. The owl is fine. |
See the above commit to the Makefile for what was going wrong - after translating from owl2obo, we were running the oboedit obo2obo to roundtrip the file. Not exactly sure why. I changed this so that oe obo2obo is only used as a validation step (e.g. to see that no artefacts OE cannot handle escape). |
This is also now fixed, all should be good in the composite metazoan world now:
|
Hi Chris, I am sorry to still comment this ticket about bug. I checked the last version (2014-09-19) both for and in both are completely missing ?????? |
When do you need this by? Is this a blocker for your release? Can you just use the bridge files such as rnordv-bridge-to-uberon (imstead of using xrefs)? It looks like I made a mistake in speccing out the development stage ontology derived files for Frederic. There isn't a way to get what you want using the files as is. You want RnorDv:0000005 'gastrula stage' to be present as an xref for the generic uberon gastrula stage. To do this, we need yet another derived file, SPCDv-xref.obo with entries like
I can then merge this in. Should not be hard to do. Just more plumbing... can I do this next week? I would like to move away from reliance on xrefs. And also, is there a new for a class like RnorDv:0000005 rat gastrula stage to exist? Do you annotate your data to these species-specific time-generic IDs? Can we just use Uberon IDs directly throughout here? |
Well, the idea was to develop the species-specific stage ontologies independently, and then to merge them with Uberon using your scripts. This is how we did it. We could change this for the future. |
…efs. Fixes issue #521. No really, fixes it this time
OK, I think we're good. Latest release will be public midnight. xrefs should be present in all cases, everything should look good in general. Some issues we already know about e.g. Dmel, dev stage vs life cycle stage. Also Medaka is lacking grouping |
hi Chris, we found that in release uberon/releases/2014-09-23 [Term] !!!!! is_a: HsapDv:0000027 ! CS20 (human) |
Already reported here: obophenotype/human-developmental-anatomy-ontology#15 |
Apologies but I just realized the heart associated veins issue is back in the 2015-01-01 release. I will check this out... |
Hi Chris,
even if xref are present for stages in Uberon, no merge applied.
example for both xref and original class:
Line 140100: id: HsapDv:0000001
Line 154855: xref: HsapDv:0000001
Thank you
Anne
The text was updated successfully, but these errors were encountered: