Update compare_df to display the diff report on column differences not just rows
#2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
approved these changes
Nov 20, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Ensure each example pipeline produces a unique output file name * Add expected example output filenames to `.gitignore` * Update `ransomware_detection` pipeline to include a unique column * Update `ransomware_detection` adding a `--pipeline_batch_size` flag defaulting to the `model_max_batch_size` avoiding a config warning * Update `Config` to call `_validate_config` from `Config.freeze` instead of the attribute setters, avoids issue where setting attributes becomes order dependent ex: ```python from morpheus.config import Config config = Config() config.model_max_batch_size = 1024 # This line triggers a warning config.pipeline_batch_size = 1024 ``` Includes changes from PR #2040 Closes #2033 Closes #2035 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #2049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents false positives when columns are missing in output
By Submitting this PR I confirm: