Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanups to example pipelines #2049

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Nov 7, 2024

Description

  • Ensure each example pipeline produces a unique output file name
  • Add expected example output filenames to .gitignore
  • Update ransomware_detection pipeline to include a unique column
  • Update ransomware_detection adding a --pipeline_batch_size flag defaulting to the model_max_batch_size avoiding a config warning
  • Update Config to call _validate_config from Config.freeze instead of the attribute setters, avoids issue where setting attributes becomes order dependent ex:
from morpheus.config import Config
config = Config()
config.model_max_batch_size = 1024 # This line triggers a warning
config.pipeline_batch_size = 1024

Includes changes from PR #2040

Closes #2033
Closes #2035

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…stamp and pid_process columns.

Add a `--pipeline_batch_size` flag defaulting to the `model_max_batch_size` avoiding a config warning
Add type hints for `run_pipeline` function arguments
… setters, avoids issue where setting attributes becomes order dependent
@dagardner-nv dagardner-nv requested review from a team as code owners November 7, 2024 21:25
@dagardner-nv dagardner-nv self-assigned this Nov 7, 2024
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Nov 7, 2024
.gitignore Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 086dc21 into nv-morpheus:branch-25.02 Nov 22, 2024
11 checks passed
@dagardner-nv dagardner-nv deleted the david-expected-data-2010 branch November 22, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
2 participants