Update MPSL and SoftDevice Controller #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.rst contains the list of changes. Signed-off-by: Sean Madigan <[email protected]>
CHANGELOG.rst contains the list of changes. Signed-off-by: Sean Madigan <[email protected]>
github-actions
bot
added
the
doc-required
rugeGerritsen
approved these changes
Oct 10, 2023
Tschet1
approved these changes
Oct 11, 2023
| * @return Returns value between 0x01-0xFF in case of error. | ||
| * See Vol 2, Part D, Error for a list of error codes and descriptions. | ||
| */ | ||
| uint8_t sdc_hci_cmd_vs_set_power_control_request_params(const sdc_hci_cmd_vs_set_power_control_request_params_t * p_params); |
There was a problem hiding this comment.
Is this something we should mention in the changelog?
There was a problem hiding this comment.
@seko-nordic , it was intentional not mention anything now, right?
There was a problem hiding this comment.
Yes this was on purpose. Reason being that it is not completely implemented, but once it is, it will replace the two existing VS commands sdc_hci_cmd_vs_set_auto_power_control_request_param and sdc_hci_cmd_vs_set_power_control_apr_handling. We want to minimize confusion with this, as customers cannot use it yet. (Answering as Sergey is in vacation at the moment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from: latest/sub/test-fw-nrfconnect-ble/master #29640.
Signed-off-by: Sean Madigan [email protected]