-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect iojs.org to nodejs.org #1557
Conversation
Using full domain redirects, because the little amount of traffic still pointing to iojs.org probably doesn't justify for full url mapping redirects. Ref: nodejs/iojs.org#432
/ping @nodejs/build |
@Trott Any thoughts about the open questions? Should we just ditch all iojs downloads completely (while we still keep stuff like Node.js 0.1.10 around)? |
+1 for removing.
If we integrate the two we could alias the old URI, so that tools wouldn't see a difference. |
/CC @rvagg |
/ping @nodejs/version-management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For nvm to work properly, it needs nodejs.org/dist to not contain io.js versions, and iojs.org/dist to only contain io.js versions.
In other words, this PR will cause massive breakage for every nvm user as-is. Please do not merge it.
What I meant by integrating, is that we do just that, i.e. keep: location /dist {
alias /home/dist/iojs/release/;
autoindex on;
default_type text/plain;
location ~ \.json$ {
add_header access-control-allow-origin *;
}
} |
As long as all the same versions are accessible, and show up in distinct lists depending on the domain requested, everything will continue to work. |
Updated the PR to keep all |
I'm not sure the config matches the discussion here. Can we be more precise with what we're trying to achieve given the above discussion? As far as the website is concerned, it's very simple and only has localisation directories plus an /images. Nothing deeper than that. We also have locations that point to distributables, they are: /dist, /download, /api, and /docs. My suggestion would be to redirect everything but those distributables, leaving them intact. Each of them lets you access specific versions and there's probably links out there on the web to them and people using weird versions that it might not be worth disrupting. Use of assets in /images might also be a concern. We've tried really hard to not break historical links on nodejs.org since we started the Foundation, maybe that should extend here too? Aside from the question of /images. If the redirect goes only in FYI here's the DNS records for iojs.org, and also we actively use @iojs.org for emails. |
@rvagg Ok, so basically leave everything as it is (redirect http+www -> https, etc.) and only redirect I updated the PR accordingly, PTAL. Removing the |
I think this looks good. Thankfully iojs.org isn't critical in the same way as nodejs.org so I'll be able to deploy and test it out. Our SSL cert expires this week so I'll need to sort that out too, either cloudflare or letsencrypt. |
switched to letsencrypt on iojs.org |
and I removed the |
Using full domain redirects, because the little amount of traffic still pointing
to iojs.org probably doesn't justify full url mapping redirects.
Ref: nodejs/iojs.org#432
Open issues:
(linking to https://github.com/nodejs/roadmap/tree/gh-pages)
*.iojs.org
also resolves to GitHub pageshttps://iojs.org/dist/
?Drop it entirely? Integrate it somehow into
https://nodejs.org/dist/
?nvm
orn
, which still point todist
?