www: letsencrypt --manual doesn't allow auto-renew, use --nginx #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchini
approved these changes
Oct 30, 2018
also add iojs.org domains
rvagg
force-pushed
the
rvagg/letsencrypt-fix
branch
from
044380f
to
e17a059
Compare
|
Made some changes here, switched from Also added Also added commands for the iojs.org domains that are now using letsencrypt (some discussion @ #1557). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found this in my commit queue, discovered a few weeks back when the dist.libuv.org cert didn't renew. It turns out that
--manualdoesn't allow for auto-renewal with certbot, you have to use--nginx, which is unfortunate, but it works and is apparently safe for our config.