Merge pull request #4 from guruchandru/mqttsubchange

Review comment changes for client id get
nlrcomcast · Sep 26, 2023 · b4b4a30 · b4b4a30
2 parents e83188f + 198cf43
commit b4b4a30
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/mqttcm_connect.c b/src/mqttcm_connect.c
@@ -1694,7 +1694,7 @@ int printList()
 int mqtt_subscribe(char *comp, char *topic)
 {
 	int rc;
-	char temp_topic[30];
+	char temp_topic[30]={'\0'};
 	if(topic != NULL && comp !=NULL)
 	{
 		int ret = isSubscribeNeeded(comp);
@@ -1718,9 +1718,18 @@ int mqtt_subscribe(char *comp, char *topic)
 		if(strcmp (comp, SUBSCRIBE_WEBCONFIG) == 0)
 		{
 			int subscribeId;
-			if( Get_Mqtt_ClientId() != NULL)
+			char *tempclient_id = NULL;
+			tempclient_id = Get_Mqtt_ClientId();
+			if( tempclient_id != NULL && strlen(tempclient_id) !=0 )
 			{
-				snprintf(temp_topic, sizeof(temp_topic), "%s%s/#", MQTT_SUBSCRIBE_TOPIC, Get_Mqtt_ClientId());
+				snprintf(temp_topic, sizeof(temp_topic), "%s%s/#", MQTT_SUBSCRIBE_TOPIC, tempclient_id);
+				MQTTCM_FREE(tempclient_id);
+				tempclient_id = NULL;
+			}
+			else
+			{
+				MqttCMError("Client id is NULL so not proceeding to subscribe\n");
+				return 1;
 			}
 			MqttCMInfo("Subscribing to wildcard topic - %s\n", temp_topic);			
 			rc = mosquitto_subscribe(mosq, &subscribeId, temp_topic, 1);