Merge pull request #3 from guruchandru/mqttsubchange

Review comment changes for PR53
nlrcomcast · Sep 25, 2023 · e83188f · e83188f
2 parents 65b9faa + 082cb52
commit e83188f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,5 @@
 build
 tags
-.vscode
 # Compiled Object files, Static and Dynamic libs (Shared Objects)
 *.o
 *.a

diff --git a/src/mqttcm_connect.c b/src/mqttcm_connect.c
@@ -1718,7 +1718,10 @@ int mqtt_subscribe(char *comp, char *topic)
 		if(strcmp (comp, SUBSCRIBE_WEBCONFIG) == 0)
 		{
 			int subscribeId;
-			sprintf(temp_topic,"%s%s/#",MQTT_SUBSCRIBE_TOPIC,Get_Mqtt_ClientId());
+			if( Get_Mqtt_ClientId() != NULL)
+			{
+				snprintf(temp_topic, sizeof(temp_topic), "%s%s/#", MQTT_SUBSCRIBE_TOPIC, Get_Mqtt_ClientId());
+			}
 			MqttCMInfo("Subscribing to wildcard topic - %s\n", temp_topic);			
 			rc = mosquitto_subscribe(mosq, &subscribeId, temp_topic, 1);
-Original file line number
+Diff line change
@@ -1,6 +1,5 @@
     build
     tags
-    .vscode
     # Compiled Object files, Static and Dynamic libs (Shared Objects)
     *.o
     *.a
@@ Expand Down @@