Skip to content

Commit

Permalink
Revert "Review comment changes for client id get"
Browse files Browse the repository at this point in the history
  • Loading branch information
nlrcomcast authored Sep 26, 2023
1 parent b4b4a30 commit 2afa91d
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions src/mqttcm_connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -1694,7 +1694,7 @@ int printList()
int mqtt_subscribe(char *comp, char *topic)
{
int rc;
char temp_topic[30]={'\0'};
char temp_topic[30];
if(topic != NULL && comp !=NULL)
{
int ret = isSubscribeNeeded(comp);
Expand All @@ -1718,18 +1718,9 @@ int mqtt_subscribe(char *comp, char *topic)
if(strcmp (comp, SUBSCRIBE_WEBCONFIG) == 0)
{
int subscribeId;
char *tempclient_id = NULL;
tempclient_id = Get_Mqtt_ClientId();
if( tempclient_id != NULL && strlen(tempclient_id) !=0 )
if( Get_Mqtt_ClientId() != NULL)
{
snprintf(temp_topic, sizeof(temp_topic), "%s%s/#", MQTT_SUBSCRIBE_TOPIC, tempclient_id);
MQTTCM_FREE(tempclient_id);
tempclient_id = NULL;
}
else
{
MqttCMError("Client id is NULL so not proceeding to subscribe\n");
return 1;
snprintf(temp_topic, sizeof(temp_topic), "%s%s/#", MQTT_SUBSCRIBE_TOPIC, Get_Mqtt_ClientId());
}
MqttCMInfo("Subscribing to wildcard topic - %s\n", temp_topic);
rc = mosquitto_subscribe(mosq, &subscribeId, temp_topic, 1);
Expand Down

0 comments on commit 2afa91d

Please sign in to comment.